jody/joplin
1
0 Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2026-10-25 02:47:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Desktop: By default, show only the editor when opening the app for the first time (#16254)

Browse Source
This commit is contained in:
Laurent Cozic authored and GitHub committed 2026-08-20 17:24:02 +01:00
1 parent a349c8e081
commit 85a61eee2d
5 files changed
+20 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

.gitignore
+1
View File
@@ -625,6 +625,7 @@ packages/app-desktop/integration-tests/util/getMainWindow.js
packages/app-desktop/integration-tests/util/ignoreFlakyReporter.js
packages/app-desktop/integration-tests/util/mockClipboard.js
packages/app-desktop/integration-tests/util/retryOnFailure.js
packages/app-desktop/integration-tests/util/seedProfileSettings.js
packages/app-desktop/integration-tests/util/setDarkMode.js
packages/app-desktop/integration-tests/util/setFilePickerResponse.js
packages/app-desktop/integration-tests/util/setMessageBoxResponse.js
.ignore.eslint
+1
View File
@@ -650,6 +650,7 @@ packages/app-desktop/integration-tests/util/getMainWindow.js
packages/app-desktop/integration-tests/util/ignoreFlakyReporter.js
packages/app-desktop/integration-tests/util/mockClipboard.js
packages/app-desktop/integration-tests/util/retryOnFailure.js
packages/app-desktop/integration-tests/util/seedProfileSettings.js
packages/app-desktop/integration-tests/util/setDarkMode.js
packages/app-desktop/integration-tests/util/setFilePickerResponse.js
packages/app-desktop/integration-tests/util/setMessageBoxResponse.js
packages/app-desktop/integration-tests/util/seedProfileSettings.ts
+12
View File
@@ -0,0 +1,12 @@
import { join } from 'path';
import { writeFile } from 'fs-extra';
// Writes the profile's settings.json before the app starts, so that these values are
// picked up during startup. Currently used to keep the editor+viewer layout that many
// integration tests rely on -- the app's default only shows the editor.
const seedProfileSettings = async (profileDirectory: string, values: Record<string, unknown>) => {
const settingFilePath = join(profileDirectory, 'settings.json');
await writeFile(settingFilePath, JSON.stringify(values), 'utf8');
};
export default seedProfileSettings;
packages/app-desktop/integration-tests/util/test.ts
+5
View File
@@ -6,6 +6,7 @@ import createStartupArgs from './createStartupArgs';
import getMainWindow from './getMainWindow';
import setDarkMode from './setDarkMode';
import evaluateWithRetry from './evaluateWithRetry';
import seedProfileSettings from './seedProfileSettings';
type StartWithPluginsResult = { app: ElectronApplication; mainWindow: Page };
@@ -75,6 +76,10 @@ export const test = base.extend<JoplinFixtures>({
const profileSubdir = join(profilePath, uuid.createNano());
await mkdirp(profileSubdir);
// Many integration tests interact with the note viewer, which is hidden by the
// app's default layout (editor only). Force the editor+viewer layout for tests.
await seedProfileSettings(profileSubdir, { noteVisiblePanes: ['editor', 'viewer'] });
await use(profileSubdir);
// For debugging purposes, attach the Joplin log file to the test:
packages/lib/models/settings/builtInMetadata.ts
+1 -1
View File
@@ -1864,7 +1864,7 @@ const builtInMetadata = (Setting: typeof SettingType) => {
appTypes: [AppType.Mobile],
isGlobal: true,
},
noteVisiblePanes: { value: ['editor', 'viewer'], type: SettingItemType.Array, storage: SettingStorage.File, isGlobal: true, public: false, appTypes: [AppType.Desktop] },
noteVisiblePanes: { value: ['editor'], type: SettingItemType.Array, storage: SettingStorage.File, isGlobal: true, public: false, appTypes: [AppType.Desktop] },
tagHeaderIsExpanded: { value: true, type: SettingItemType.Bool, public: false, appTypes: [AppType.Desktop] },
folderHeaderIsExpanded: { value: true, type: SettingItemType.Bool, public: false, appTypes: [AppType.Desktop] },
syncReportIsVisible: { value: false, type: SettingItemType.Bool, public: false, appTypes: [AppType.Desktop] },