jody/yacy_search_server
1
0 Fork 0
mirror of https://github.com/yacy/yacy_search_server.git synced 2026-10-25 05:54:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix error handling for client disconnects

Browse Source
This commit is contained in:
Michael Peter Christen committed 2026-07-30 23:41:05 +02:00
1 parent ece7985d94
commit 49d3428a45
5 files changed
+181 -5
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/java/net/yacy/http/Jetty12HttpServerTest.java
+24
View File
@@ -8,10 +8,13 @@ import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.lang.reflect.Proxy;
import java.net.Socket;
import java.net.SocketException;
import java.nio.channels.ClosedChannelException;
import java.nio.charset.StandardCharsets;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
@@ -27,6 +30,7 @@ import javax.servlet.http.HttpServletResponse;
import org.eclipse.jetty.ee8.security.authentication.DigestAuthenticator;
import org.eclipse.jetty.ee8.servlet.ServletContextHandler;
import org.eclipse.jetty.ee8.servlet.ServletHolder;
import org.eclipse.jetty.io.EofException;
import org.eclipse.jetty.security.UserIdentity;
import org.eclipse.jetty.server.Handler;
import org.eclipse.jetty.server.Request;
@@ -344,6 +348,26 @@ public class Jetty12HttpServerTest {
/** Exception barrier around the complete request pipeline. */
public static class CrashProtectionHandlerTest {
@Test
public void recognizesClientDisconnectFailuresThroughCauseChain() {
assertTrue(Jetty12HttpServer.CrashProtectionHandler.isClientDisconnect(
new IOException("Broken pipe")));
assertTrue(Jetty12HttpServer.CrashProtectionHandler.isClientDisconnect(
new SocketException("Connection reset")));
assertTrue(Jetty12HttpServer.CrashProtectionHandler.isClientDisconnect(
new IllegalStateException("wrapped", new EofException("closed"))));
assertTrue(Jetty12HttpServer.CrashProtectionHandler.isClientDisconnect(
new ClosedChannelException()));
}
@Test
public void doesNotHideUnrelatedIoOrApplicationFailures() {
assertFalse(Jetty12HttpServer.CrashProtectionHandler.isClientDisconnect(
new IOException("disk failure")));
assertFalse(Jetty12HttpServer.CrashProtectionHandler.isClientDisconnect(
new IllegalStateException("COMMITTED")));
}
@Test
public void convertsSynchronousHandlerFailureTo500Response() throws Exception {
final Server server = new Server();