Web: Fixes #15601: Fix S3 sync failing with getReader TypeError (#15851)

Co-authored-by: Laurent Cozic <laurent22@users.noreply.github.com>
This commit is contained in:
Antonio VargasandLaurent Cozic authored and GitHub committed 2026-07-09 18:22:31 +01:00
1 parent 0f52c0cfb5
commit c2b04f26df
3 files changed
+61 -1183

No files matched your search

+6
View File
@@ -57,6 +57,9 @@ class SyncTargetAmazonS3 extends BaseSyncTarget {
forcePathStyle: Setting.value('sync.8.forcePathStyle'), // Older implementations may not support more modern access, so we expose this to allow people the option to toggle.
endpoint: Setting.value('sync.8.url'),
ignoreTlsErrors: Setting.value('net.ignoreTlsErrors'),
// Keep checksums opt-in: aws-sdk-js-v3 >= 3.729.0 defaults to sending CRC32 headers that many S3-compatible providers reject.
requestChecksumCalculation: 'WHEN_REQUIRED',
responseChecksumValidation: 'WHEN_REQUIRED',
};
}
@@ -89,6 +92,9 @@ class SyncTargetAmazonS3 extends BaseSyncTarget {
forcePathStyle: options.forcePathStyle(),
endpoint: options.url(),
ignoreTlsErrors: options.ignoreTlsErrors(),
// Keep checksums opt-in: aws-sdk-js-v3 >= 3.729.0 defaults to sending CRC32 headers that many S3-compatible providers reject.
requestChecksumCalculation: 'WHEN_REQUIRED',
responseChecksumValidation: 'WHEN_REQUIRED',
};
const api = new S3Client(apiOptions);
+2 -2
View File
@@ -47,8 +47,8 @@
},
"dependencies": {
"@adobe/css-tools": "4.4.4",
"@aws-sdk/client-s3": "3.296.0",
"@aws-sdk/s3-request-presigner": "3.296.0",
"@aws-sdk/client-s3": "3.928.0",
"@aws-sdk/s3-request-presigner": "3.928.0",
"@joplin/fork-htmlparser2": "^4.1.63",
"@joplin/fork-sax": "^1.2.67",
"@joplin/fork-uslug": "^2.0.6",
+53 -1181
View File
File diff suppressed because it is too large. Load diff