Chore: Fix test warnings

packages/app-desktop/gui/ChatPanel/ChatPanel.test.tsx

@@ -6,7 +6,7 @@ import Note from '@joplin/lib/models/Note';
 import CommandService from '@joplin/lib/services/CommandService';
 import { runNoteChat } from '@joplin/lib/services/ai/noteChat';
 import { ChatRole } from '@joplin/lib/services/ai/types';
-import { setupDatabaseAndSynchronizer, switchClient } from '@joplin/lib/testing/test-utils';
+import { setupDatabaseAndSynchronizer, switchClient, withWarningSilenced } from '@joplin/lib/testing/test-utils';
 import appReducer, { AiChatMessage, createAppDefaultState, createAppDefaultWindowState } from '../../app.reducer';
 import ChatPanel from './ChatPanel';
 import { WindowIdContext } from '../NewWindowOrIFrame';
@@ -186,8 +186,10 @@ describe('ChatPanel', () => {
 		jest.mocked(runNoteChat).mockRejectedValue(new Error('Network down'));
 		const view = renderPanel({ conversationId: 'chat-1', noteId: 'note-a', noteTitle: 'A', dispatch: jest.fn() });
 		fireEvent.change(view.getByRole('textbox'), { target: { value: 'Question' } });
-		await act(async () => { fireEvent.click(view.getByRole('button', { name: 'Send' })); });
-		await waitFor(async () => expect(await ChatConversation.messages('chat-1')).toMatchObject([{ role: 'error', text: 'Network down' }]));
+		await withWarningSilenced(/Chat failed/, async () => {
+			await act(async () => { fireEvent.click(view.getByRole('button', { name: 'Send' })); });
+			await waitFor(async () => expect(await ChatConversation.messages('chat-1')).toMatchObject([{ role: 'error', text: 'Network down' }]));
+		}, { requireWarning: true });
 	});
 
 	it('should assign an ID before messages are added to a new conversation', async () => {

packages/app-desktop/gui/PromptDialog.test.ts

@@ -17,6 +17,8 @@ describe('PromptDialog', () => {
 			answer: null,
 		});
 		instance.state = { visible: true, answer: 'some-answer' };
+		// The instance is never mounted, so a real setState() call would trigger a React warning
+		instance.setState = jest.fn();
 		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Accessing private property for test setup
 		(instance as unknown as any).menuIsOpened_ = menuIsOpened;
 

packages/utils/ipc.test.ts

@@ -1,20 +1,35 @@
 import { readFile } from 'fs/promises';
 import { createTempDir } from './fs.test';
-import { newHttpError, sendMessage, startServer, stopServer } from './ipc';
+import { IpcMessageHandler, IpcServer, newHttpError, sendMessage, startServer as startServerBase, stopServer } from './ipc';
 
 const getRandomPort = () => {
-	return Math.floor(Math.random() * (65535 - 20000 + 1)) + 20000;
+	// Stay below the OS ephemeral port ranges (Linux: 32768+, macOS/Windows: 49152+), otherwise an outgoing
+	// connection may hold the port, which `tcp-port-used` reports as free but `listen()` rejects with EADDRINUSE.
+	return Math.floor(Math.random() * 20000) + 10000;
+};
+
+let startedServers: IpcServer[] = [];
+
+const startServer = async (startPort: number, secretKeyFilePath: string, messageHandler: IpcMessageHandler) => {
+	const server = await startServerBase(startPort, secretKeyFilePath, messageHandler);
+	startedServers.push(server);
+	return server;
 };
 
 describe('ipc', () => {
 
+	afterEach(async () => {
+		for (const server of startedServers) await stopServer(server);
+		startedServers = [];
+	});
+
 	it('should send and receive messages', async () => {
 		const tempDir = await createTempDir();
 		const secretFilePath = `${tempDir}/secret.txt`;
 		const serverPort1 = getRandomPort();
 		const serverPort2 = serverPort1 + 5;
 
-		const server1 = await startServer(serverPort1, secretFilePath, async (request) => {
+		await startServer(serverPort1, secretFilePath, async (request) => {
 			if (request.action === 'testing') {
 				return {
 					text: 'hello1',
@@ -24,7 +39,7 @@ describe('ipc', () => {
 			throw newHttpError(404);
 		});
 
-		const server2 = await startServer(serverPort2, secretFilePath, async (request) => {
+		await startServer(serverPort2, secretFilePath, async (request) => {
 			if (request.action === 'testing') {
 				return {
 					text: 'hello2',
@@ -83,9 +98,6 @@ describe('ipc', () => {
 				{ port: serverPort2, response: { text: 'hello2' } },
 			]);
 		}
-
-		await stopServer(server1);
-		await stopServer(server2);
 	});
 
 	it('should not process message if secret is invalid', async () => {
@@ -93,7 +105,7 @@ describe('ipc', () => {
 		const secretFilePath = `${tempDir}/secret.txt`;
 		const serverPort = getRandomPort();
 
-		const server = await startServer(serverPort, secretFilePath, async (request) => {
+		await startServer(serverPort, secretFilePath, async (request) => {
 			if (request.action === 'testing') {
 				return {
 					text: 'hello1',
@@ -124,8 +136,6 @@ describe('ipc', () => {
 
 			expect(responses.length).toBe(1);
 		}
-
-		await stopServer(server);
 	});
 
 });